From 404c7944190f939c3aa2cb9ede4122b52b066f4f Mon Sep 17 00:00:00 2001 From: Vadim Makeev Date: Sun, 16 Dec 2012 17:10:46 +0400 Subject: [PATCH] JHint advice --- Contributing.md | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/Contributing.md b/Contributing.md index 4920279..2dd6527 100644 --- a/Contributing.md +++ b/Contributing.md @@ -15,15 +15,17 @@ Before starting to contribute to Shower please read through [Issues](https://git ## Process -To contribute to Shower fork needed repository and start making changes. Don't forget to add upstream link to main original repository and keep your fork updated. When you finished send pull request back to original repository and supply clear description or link to existing issue. +To contribute to Shower fork needed repository and start making changes. Don't forget to add upstream link to original repository and keep your fork updated. When you finished send pull request back to original repository and supply clear description or link to existing issue. ## Code style -Please keep existing code style while contributing to Shower and be ready for code review by Shower authors and contributors. By historical reasons, Shower project is using tabs instead of spaces to indent code. It's not a big deal to keep this rule while contributing using you code editor options, even if your code style is 13.4 spaces. So, please use tabs instead of spaces for indentation. +Please keep existing code style while contributing to Shower and be ready for code review by Shower authors and contributors. It's strognly recommended to validate your JavaScript changes using [JSHint](http://jshint.com/) + +By historical reasons, Shower project is using tabs instead of spaces code indentation. It's not a big deal to keep this rule while contributing using you code editor options, even if your code style is 13.4 spaces. ## Language -English is the main language for Shower project. All discussions and commit messages should be in English no matter if it's good or bad. The second language of Shower is Russian. Offical Shower themes are always contains Cyrillic support for web fonts and support for Russian typography in text styling. All documentation to Shower is always localized to Russian. +English is the main language for Shower project. All discussions and commit messages should be in English no matter if it's good or bad. The second language of Shower is Russian. Offical Shower themes are always compatible with Cyrillic and Russian typography. All documentation to Shower is always localized to Russian. --- If you have any question please ask [@shower_me](http://twitter.com/shower_me/) or file an [issue](https://github.com/shower/shower/issues?state=open). \ No newline at end of file