From 251afb1551a11fb6662076dea08e2eb5f2dda1f3 Mon Sep 17 00:00:00 2001 From: Tony Ganch Date: Fri, 28 Jun 2013 16:11:10 +0400 Subject: [PATCH 1/3] Update Contributing.md Fix link to Template repository. Add link to Jekyller. --- Contributing.md | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/Contributing.md b/Contributing.md index 0c3dbfd..1487e7c 100644 --- a/Contributing.md +++ b/Contributing.md @@ -1,11 +1,12 @@ # Contributing to Shower -You're always welcome to contibute! There are three repositories in Shower project: +You're always welcome to contibute! There are five repositories in Shower project: - [Shower](https://github.com/shower/shower) engine with Ribbon theme -- [Template](https://github.com/shower) for Shower engine and built-in themes +- [Template](https://github.com/shower/template) for Shower engine and built-in themes - [Ribbon](https://github.com/shower/ribbon) theme for Shower - [Bright](https://github.com/shower/bright) theme for Shower +- [Jekyller](https://github.com/shower/jekyller) generator for Shower The most important part of the project is the [Shower](https://github.com/shower/shower) repository, containing [shower.js](https://github.com/shower/shower/blob/master/shower.js) file. @@ -29,4 +30,4 @@ By historical reasons, Shower project is using tabs instead of spaces for code i English is the main language for Shower project. All discussions and commit messages should be in English no matter if it's good or bad. The second language of Shower is Russian. Offical Shower themes are always compatible with Cyrillic and Russian typography. All documentation to Shower is always localized to Russian. --- -If you have any question please ask [@shower_me](http://twitter.com/shower_me/) or file an [issue](https://github.com/shower/shower/issues?state=open). \ No newline at end of file +If you have any question please ask [@shower_me](http://twitter.com/shower_me/) or file an [issue](https://github.com/shower/shower/issues?state=open). From 17ed32aa333ab04993d5ef7499ab2d999d2a5d52 Mon Sep 17 00:00:00 2001 From: Tony Ganch Date: Fri, 28 Jun 2013 16:24:55 +0400 Subject: [PATCH 2/3] Update Contributing.md Fix a typo, add some commas. --- Contributing.md | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/Contributing.md b/Contributing.md index 1487e7c..4245555 100644 --- a/Contributing.md +++ b/Contributing.md @@ -12,22 +12,22 @@ The most important part of the project is the [Shower](https://github.com/shower ## Issues -Before starting to contribute to Shower please read through [Issues](https://github.com/shower/shower/issues?state=open) to see opened bugs and feature requests. If you have any feature to add to Shower, please make sure that you file an issue with your ideas first. If you've found a bug and want to fix it, please file an issue first. It might be a feature! +Before contributing to Shower, please read through [Issues](https://github.com/shower/shower/issues?state=open) to see open bugs and feature requests. If you have any feature to add to Shower, please make sure that you file an issue with your ideas first. If you've found a bug and want to fix it, please file an issue first. It might be a feature! ## Process -To contribute to Shower fork needed repository and start making changes. Don't forget to add upstream link to original repository and keep your fork updated. When you finished send pull request back to original repository and supply clear description or link to existing issue. +To contribute to Shower, fork needed repository and start making changes. Don't forget to add upstream link to original repository and keep your fork updated. When you finish, send pull request back to original repository and supply clear description or link to existing issue. ## Code style -Please keep existing code style while contributing to Shower and be ready for code review by Shower authors and contributors. It's strognly recommended to validate your JavaScript changes using [JSHint](http://jshint.com/). +Please keep existing code style while contributing to Shower and be ready for code review by Shower authors and contributors. It's strongly recommended to validate your JavaScript changes using [JSHint](http://jshint.com/). By historical reasons, Shower project is using tabs instead of spaces for code indentation. It's not a big deal to keep this rule while contributing using you code editor options, even if your code style is 13.4 spaces. ## Language -English is the main language for Shower project. All discussions and commit messages should be in English no matter if it's good or bad. The second language of Shower is Russian. Offical Shower themes are always compatible with Cyrillic and Russian typography. All documentation to Shower is always localized to Russian. +English is the main language for Shower project. All discussions and commit messages should be in English, no matter if it's good or bad. The second language of Shower is Russian. Offical Shower themes are always compatible with Cyrillic and Russian typography. All documentation to Shower is always localized to Russian. --- -If you have any question please ask [@shower_me](http://twitter.com/shower_me/) or file an [issue](https://github.com/shower/shower/issues?state=open). +If you have any question, please ask [@shower_me](http://twitter.com/shower_me/) or file an [issue](https://github.com/shower/shower/issues?state=open). From 41d8978f3c9f23a193e435770264ed3ee933fd96 Mon Sep 17 00:00:00 2001 From: Tony Ganch Date: Fri, 28 Jun 2013 16:28:22 +0400 Subject: [PATCH 3/3] Update Contributing.md --- Contributing.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Contributing.md b/Contributing.md index 4245555..624d291 100644 --- a/Contributing.md +++ b/Contributing.md @@ -30,4 +30,4 @@ By historical reasons, Shower project is using tabs instead of spaces for code i English is the main language for Shower project. All discussions and commit messages should be in English, no matter if it's good or bad. The second language of Shower is Russian. Offical Shower themes are always compatible with Cyrillic and Russian typography. All documentation to Shower is always localized to Russian. --- -If you have any question, please ask [@shower_me](http://twitter.com/shower_me/) or file an [issue](https://github.com/shower/shower/issues?state=open). +If you have any questions, please ask [@shower_me](http://twitter.com/shower_me/) or file an [issue](https://github.com/shower/shower/issues?state=open).