From 93b267699435d36c3bac9c465f400b60d6fcaa65 Mon Sep 17 00:00:00 2001 From: Andrei Zimin Date: Thu, 14 May 2026 13:25:41 +0300 Subject: [PATCH] =?UTF-8?q?fix(ui):=20wrap=20remaining=20UUIDs=20into=20Us?= =?UTF-8?q?erCell=20=E2=80=94=203=20missed=20spots?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit MR !177 added /admin/users/{sub}/display + UserCell + useUserDisplay, but only some renderers were migrated. Three places still rendered raw UUID strings: 1. reviews.tsx:466 — record draft drawer ("Согласование draft" header) showed `{draft.makerId}` raw. Tables on the same page already use . Verified via prod staging: soloviev.da approved a record draft today and the drawer header showed the maker as "77ec2cc8-98e3-4d70-8037-94038fcbde67" instead of the username. 2. RecordHistoryDrawer.tsx:110 — version history `updatedBy` raw. 3. webhooks.$id.tsx:235 — webhook subscription `createdBy` raw. All three switched to , matching the existing pattern. Added the import where missing. Wrapped each in inline-flex so the UserCell sits next to the label cleanly. No backend / API changes — same /admin/users/{sub}/display endpoint populated by JwtUserCaptureFilter (MR !177). --- .../src/components/record/RecordHistoryDrawer.tsx | 6 ++++-- ordinis-admin-ui/src/routes/reviews.tsx | 4 ++-- ordinis-admin-ui/src/routes/webhooks.$id.tsx | 5 +++-- 3 files changed, 9 insertions(+), 6 deletions(-) diff --git a/ordinis-admin-ui/src/components/record/RecordHistoryDrawer.tsx b/ordinis-admin-ui/src/components/record/RecordHistoryDrawer.tsx index 726a262..45eee68 100644 --- a/ordinis-admin-ui/src/components/record/RecordHistoryDrawer.tsx +++ b/ordinis-admin-ui/src/components/record/RecordHistoryDrawer.tsx @@ -4,6 +4,7 @@ import { Badge, Button, Drawer, LoadingBlock, QueryErrorState } from '@/ui' import { ArrowsLeftRightIcon, ArrowCounterClockwiseIcon, BracketsCurlyIcon, InfoIcon } from '@phosphor-icons/react' import { useRecordHistory } from '@/api/queries' import { RecordDependentsPanel } from '@/components/lineage/RecordDependentsPanel' +import { UserCell } from '@/lib/useUserDisplay' type Props = { open: boolean @@ -106,8 +107,9 @@ export const RecordHistoryDrawer = ({ )} {rec.updatedBy && ( -
- {t('history.updatedBy')}: {rec.updatedBy} +
+ {t('history.updatedBy')}:{' '} +
)}
diff --git a/ordinis-admin-ui/src/routes/reviews.tsx b/ordinis-admin-ui/src/routes/reviews.tsx index 7b8b949..925d85d 100644 --- a/ordinis-admin-ui/src/routes/reviews.tsx +++ b/ordinis-admin-ui/src/routes/reviews.tsx @@ -526,8 +526,8 @@ function ReviewDrawer({ draftId, onClose }: DrawerProps) {
{draft.operation} {draft.businessKey} - - {t('reviews.drawer.maker')}: {draft.makerId} + + {t('reviews.drawer.maker')}: {t('reviews.drawer.submitted')}:{' '} diff --git a/ordinis-admin-ui/src/routes/webhooks.$id.tsx b/ordinis-admin-ui/src/routes/webhooks.$id.tsx index 3f1c36a..d982a3f 100644 --- a/ordinis-admin-ui/src/routes/webhooks.$id.tsx +++ b/ordinis-admin-ui/src/routes/webhooks.$id.tsx @@ -1,6 +1,7 @@ import { useState } from 'react' import { createFileRoute, Link } from '@tanstack/react-router' import { useTranslation } from 'react-i18next' +import { UserCell } from '@/lib/useUserDisplay' import { Alert, Badge, @@ -231,8 +232,8 @@ function WebhookDetailPage() { {data.hmacSecret} - - {data.createdBy} · {new Date(data.createdAt).toLocaleString()} + + · {new Date(data.createdAt).toLocaleString()}