JHint advice

This commit is contained in:
Vadim Makeev 2012-12-16 17:10:46 +04:00
parent e104d14ae8
commit 404c794419
1 changed files with 5 additions and 3 deletions

View File

@ -15,15 +15,17 @@ Before starting to contribute to Shower please read through [Issues](https://git
## Process
To contribute to Shower fork needed repository and start making changes. Don't forget to add upstream link to main original repository and keep your fork updated. When you finished send pull request back to original repository and supply clear description or link to existing issue.
To contribute to Shower fork needed repository and start making changes. Don't forget to add upstream link to original repository and keep your fork updated. When you finished send pull request back to original repository and supply clear description or link to existing issue.
## Code style
Please keep existing code style while contributing to Shower and be ready for code review by Shower authors and contributors. By historical reasons, Shower project is using tabs instead of spaces to indent code. It's not a big deal to keep this rule while contributing using you code editor options, even if your code style is 13.4 spaces. So, please use tabs instead of spaces for indentation.
Please keep existing code style while contributing to Shower and be ready for code review by Shower authors and contributors. It's strognly recommended to validate your JavaScript changes using [JSHint](http://jshint.com/)
By historical reasons, Shower project is using tabs instead of spaces code indentation. It's not a big deal to keep this rule while contributing using you code editor options, even if your code style is 13.4 spaces.
## Language
English is the main language for Shower project. All discussions and commit messages should be in English no matter if it's good or bad. The second language of Shower is Russian. Offical Shower themes are always contains Cyrillic support for web fonts and support for Russian typography in text styling. All documentation to Shower is always localized to Russian.
English is the main language for Shower project. All discussions and commit messages should be in English no matter if it's good or bad. The second language of Shower is Russian. Offical Shower themes are always compatible with Cyrillic and Russian typography. All documentation to Shower is always localized to Russian.
---
If you have any question please ask [@shower_me](http://twitter.com/shower_me/) or file an [issue](https://github.com/shower/shower/issues?state=open).